can anybody clue me in on some ways to train quicker becuase its takin me forever nd i need to beat elite four

It depends, which game are you playing? If you're playing Ruby/Sapphire, wait for trainers to rematch you in the "Trainer's Eyes" feature on your PokéNav, they will become stronger each time (until they reach their final stage). If you're playing Emerald, go to the Sky Pillar, there are very powerful Pokémon there.

He needs to beat the Elite Four, you can't go to Sky Pillar until you beat them.

I use EXP.Share. Also, I fight the Pokemon in the area I've just been to, since their levels are usually higher.

So as Ho-oh_Rules said, Trainer's Eyes for R/S, for Emerald, I'd rebattle the Gym Leaders.

You can in Emerald, since you can catch Rayquaza before the elite four.

Oh, do that then.

It's been a while since I played emerald, sorry. :x

Either in the Sky Pillar (Emerald) as Ho-oh_rules said or possibly in victory road if you have Ruby or Sapphire. Also, battling trainers in your pokenav can help you gain a lot of moolah as well, which you can spend on revives and full restores. Use the amulet coin to get more money (see your mom after beating your dad), and target rich boys, ladies, and gentlemen first since they have a bunch of money to pay, and being doubled by an amulet coin gets some amounts up to Y12,000.

With the money and training, you can get high level pokemon and buy coins at the casino, and then purchase good TM's like thunderbolt and ice beam.

I know this may sound a bit silly, and slightly off-topic but..
Where do you get the Exp. Share from again?

Is it in Rustboro, when you go back to see the Devon President?