For comepeitive battle im not sure whats better moonlight or wish?
moonlight heals u during that one turn
wish waits for 2turns
anyone have suggestions?

I think Wish is better, because you can set it up, and then switch or baton pass to another pokemon.

dont have baton pass : /

Then switch, or get a pokemon with baton pass. It completely depends on what you're using it for. If you have another pokemon that needs to heal, you could wish, substitute, then switch. If you need immediate healing, use moonlight, but moonlight depends on what the wheather is, so a little more information would be helpful such as what pokemon you're using, what tier you want to use it in, and what its moveset is.

lol well telling by you using moonlight vs wish..umbreon is the only pokemon that can learn both of those moves...for umbreon...wish would be better....he's a great wish passer...you would do wish mainly early in the battle so that umbreon can heal himself and set up at the same time...moonlight is good for immediate recovery, however..sandstorm is too common lol (honestly it is because waayy too common nowadays, lol it's becoming standard gameplay)...and wish is a much better support move...you can wish before someone sends in your counter to umbreon...IE Infernape, lucario...and also wish can be paired with protect/toxic...it works well with vaporeon...toxic lasts longer, and wish is immediate health...so that's also an option

Well, as long as the idea is to put Wish on a slow pokemon (ie -Spd Nature Umbreon) so it can Baton Pass a safe Wish to the injured pokemon without the newcomer taken a hit first. Otherwise Wish passing is the same as using Wish then switching out normally.

And yeah, I agree with the above that with the incredibly common occurance of Sandstream/Sandstorm pokes Moonlight is much more unreliable than it ever was. You can always pack some Sunny Day support if it happens to fit the rest of your teams theme though. Wish is still better utility most of the time though.

I believe Clefable also learns both.

O yeah hahah forgot about that one too...my bad lol

I would use Wish,because D/P bring the Age of Sandstorm up...
So you have great cahnces of finding Sandstorm teams...

i think wish is better you can heal your other pokemon